Use more quotations in TH module #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ah I see that your code too gets the unused pattern binding warning in TH.... I had them too and a a small rewrite fixed it for me, but I don't know when that triggers... |
A seemingly bogus warning in GHC < 9.6 forces us to write some patterns
oddly to silence the warning.
For instance, instead of writing
[d|
Circuit $(varP ...) = ...
|]
we're forced to write
[d|
$[p| Circuit $(varP ...) |] = ...
|]
where we wrap a pattern P as $[p| P |] .
DigitalBrains1
force-pushed
the
improve-th
branch
from
7cdfe5c to
1af0259
Compare
|
Yes, and the minimal fix is really silly. Instead of writing [d|
Circuit $(varP ...) = ...
|]we wrap it as [d|
$[p| Circuit $(varP ...) |] = ...
|]where we wrap a pattern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use more quotations and less "bare" TH constructions.
This was intended as a change to #117, but it was already merged.